Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shared dependencies to the workspace crate #189

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Move shared dependencies to the workspace crate #189

merged 1 commit into from
Apr 25, 2024

Conversation

piotr-roslaniec
Copy link

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

  • Deduplicates where needed and moves dependencies to ./Cargo.toml
  • Generated with cargo autoinherit

Why it's needed:

  • Prevents conflicting child dependency version, a source of confusion when debugging conflicts with cargo tree

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review March 20, 2024 16:04
@piotr-roslaniec piotr-roslaniec merged commit be98542 into nucypher:rocknroll Apr 25, 2024
11 checks passed
@piotr-roslaniec piotr-roslaniec deleted the workspace-deps branch April 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cygnusv cygnusv Awaiting requested review from cygnusv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@piotr-roslaniec